Limitation (or Feature) on Tendermint

qizhou · April 7, 2020, 11:44pm

However, current mempool implementation of TM doesn’t consider actual gas used:

tendermint/tendermint/blob/f70785bc957204c78b6da58a1ad35196815a418a/mempool/clist_mempool.go#L498


		// Check total size requirement
		aminoOverhead := types.ComputeAminoOverhead(memTx.tx, 1)
		if maxBytes > -1 && totalBytes+int64(len(memTx.tx))+aminoOverhead > maxBytes {
			return txs
		}
		totalBytes += int64(len(memTx.tx)) + aminoOverhead
		// Check total gas requirement.
		// If maxGas is negative, skip this check.
		// Since newTotalGas < masGas, which
		// must be non-negative, it follows that this won't overflow.
		newTotalGas := totalGas + memTx.gasWanted
		if maxGas > -1 && newTotalGas > maxGas {
			return txs
		}
		totalGas = newTotalGas
		txs = append(txs, memTx.tx)
	}
	return txs
}


func (mem *CListMempool) ReapMaxTxs(max int) types.Txs {

This means that an attacker can send tx with large gasWanted, but with very small gasUsed, and then essentially ddos the network.

Topic		Replies	Views
Validate a Remote Chain Header in CosmosSDK Core Technicals	1	740	May 6, 2020
Tendermint: local cluster instruction General Questions	1	1226	February 16, 2023
POSW locking more coins that required Minings	7	1090	July 20, 2020
Call for help: come and test our multinative token auction! General Questions	11	1286	June 25, 2020
[Official Announcement] QuarkChain TPS Competition Update II: 200,000+ TPS Achieved, Challenge Difficulty Upgrade TPS Competiton	0	639	December 3, 2019

Limitation (or Feature) on Tendermint

Related topics